Add documentation for Palette shared binding#1874
Merged
tannewt merged 3 commits intoadafruit:masterfrom May 14, 2019
Merged
Conversation
Add documentation for the palette subscript operator and how to use it.
ladyada
reviewed
May 10, 2019
Member
ladyada
left a comment
ladyada
left a comment
There was a problem hiding this comment.
i think you can also set it to None if you want transparant
ladyada
previously approved these changes
May 10, 2019
Member
|
lgtm but ill let @tannewt do another check in case i missed something :) |
tannewt
requested changes
May 13, 2019
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
None doesn't currently mean transparent. It's not a bad idea though.
For now I think it will throw an error so please update the docs for as it is now.
Remove None, add in byte and bytearray examples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add documentation for the palette subscript operator and how to use it.